Replies: 4 comments 9 replies
-
No real PRs pending from my side. Milestone and date are fine by me. SFOS 4.4 is coming RSN^TM, lets see if that breaks anything for us. |
Beta Was this translation helpful? Give feedback.
-
References: ***@***.***>
***@***.***>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: base64
Date: Fri, 11 Feb 2022 08:20:12 +0000
Message-ID: ***@***.***>
MIME-Version: 1.0
QXMgc29vbiBhcyB5b3UgYXJlIGNvbWZvcnRhYmxlLA0KVGhhbmtzDQoNCk9uIEZyaWRheSwgRmVi
cnVhcnkgMTEsIDIwMjIsIG9sZiB3cm90ZToNCj4gSXQgaXMgb2J2aW91cyBieSBub3cgdGhhdCB0
aGVyZSB3aWxsIG5vdCBiZSBhIFNhaWxmaXNoT1MgNC40LjAgcmVsZWFzZSBiZWZvcmUgRmVicnVh
cnkgMTV0aCwgYmVjYXVzZSB0aGVyZSBpcyBubyBFQSByZWxlYXNlIHlldCAod2hpY2ggaXMgc3Rp
bGwgb3V0IGZvciBhdCBsZWFzdCBhIHdlZWssIGFsdGhvdWdoIG5vdCBmb3IgbWFueSB3ZWVrcyBs
aWtlIHllYXJzIGFnbykuICBBbmQgSm9sbGEncyAic29vbuKEoiIsIHdoaWNoIHdhcyBub3QgZXZl
biBzdGF0ZWQgZm9yIHRoaXMsIG1heSB0YWtlIGFueSB0aW1lLCBhcyB3ZSBrbm93Lg0KPiANCj4g
U28gZWl0aGVyIHdlIChiYXNpY2FsbHkgSSkgcmVsZWFzZSB0aGlzIG9yIG5leHQgd2Vla2VuZCwg
d2hpY2ggd291bGQgZnJlZSB0aGUgbWFzdGVyIGJyYW5jaCBmb3IgbWVyZ2VzIGFnYWluLCBvciB3
ZSBrZWVwIG9uIHdhaXRpbmcuICBJIGFtIGluY2xpbmVkIHRvIHJlbGVhc2Ugb24gdGhpcyBTdW5k
YXkgb3IgbmV4dCB3ZWVrZW5kLCBkZXBlbmRpbmcgb24gdGhlIHdlYXRoZXIgKGZvciBjeWNsaW5n
KSwgYnV0IGlmIHlvdSBoYXZlIHJlYXNvbnMgb3IgcHJlZmVyZW5jZXMgZm9yIGFueSBvZiB0aGVz
ZSBvciBvdGhlciBkYXRlcywgcGxlYXNlIGxldCBtZSBrbm93LiAgT3BpbmlvbnMsIEBuZXBocm9z
IGFuZCBAYjEwMGRpYW4/DQo+IA0KPiAtLSANCj4gUmVwbHkgdG8gdGhpcyBlbWFpbCBkaXJlY3Rs
eSBvciB2aWV3IGl0IG9uIEdpdEh1YjoNCj4gaHR0cHM6Ly9naXRodWIuY29tL3NhaWxmaXNob3Mt
cGF0Y2hlcy9wYXRjaG1hbmFnZXIvZGlzY3Vzc2lvbnMvMjQ0I2Rpc2N1c3Npb25jb21tZW50LTIx
NTQ2NTgNCj4gWW91IGFyZSByZWNlaXZpbmcgdGhpcyBiZWNhdXNlIHlvdSB3ZXJlIG1lbnRpb25l
ZC4NCj4gDQo+IE1lc3NhZ2UgSUQ6IDxzYWlsZmlzaG9zLXBhdGNoZXMvcGF0Y2htYW5hZ2VyL3Jl
cG8tZGlzY3Vzc2lvbnMvMjQ0L2NvbW1lbnRzLzIxNTQ2NThAZ2l0aHViLmNvbQ0KDQotLSANClNl
bnQgZnJvbSBteSBTYWlsZmlzaCBkZXZpY2U=
|
Beta Was this translation helpful? Give feedback.
-
Well, so I "just did it":
|
Beta Was this translation helpful? Give feedback.
-
Done, see Patchmanager's releases at GitHub, at OpenRepos and submitted a request at SailfishOS:Chum OBS. P.S.: This created quite some "fallout", i.e., issues and PRs at various projects. |
Beta Was this translation helpful? Give feedback.
-
I am basically finished with what I intended to achieve for PM 3.2.1, only the updated translations from Transifex triggered by the big "strings rework"-PR #227 still have to come in (well, SV already has, because eson is always very quick, and I am taking care about the DE one and may adapt some easy things in the NL one) and the fix-up PR #240 for that still has to be merged.
Side note: In addition to the "strings rework", my other goal was to consolidate and generalise the function
mangle_libpath
inpm_apply
. While I have the impression that this worked well, including the subsequent optimisation by @nephros and our mutual reviews (which resulted in some back and forth, but ultimately in much better code), one thing I am slightly concerned about still is corresponding C++ code for 32-/64-bit mangling, as detailed before: I took a look at it and found nothing, but due to my slim C++ know-how and lack of experience that does not mean much; maybe you (@nephros and @b100dian) can spare the time to re-review you code once more, also under the aspect thatpm_apply
does cover many more cases than before (i.e.: multiple, different library paths on the mangle list to convert in a single Patch, multiple locations to convert the same mangle-able library path in a single Patch etc.).If you have other issues or PRs which you want to be in PM 3.2.1, please assign them to the milestone "3.2.1".
Note that I have set the due date to 15. February 2022, which is just a goal (hence to be handled flexibly), but new issues or PRs assigned to the milestone "3.2.1" shall be realistically resolvable before 1. February, so they can be well reviewed and tested before the due date a fortnight later. OTOH I do not mind to release earlier than 15. Feb., if appropriate.
Side note: I also intend to care about the process at SailfishOS:Chum for this release (so I can become accustomed to it), if nobody else is keen on doing this.
Beta Was this translation helpful? Give feedback.
All reactions