Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature suggestions #3

Open
1 of 3 tasks
kidonng opened this issue Aug 25, 2021 · 2 comments
Open
1 of 3 tasks

Feature suggestions #3

kidonng opened this issue Aug 25, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@kidonng
Copy link
Contributor

kidonng commented Aug 25, 2021

Hi there! This is definitely one of the most useful gh extensions right now, and it compliments gh very well. I don't think we need to implement the whole GitHub into it (not to mention it's impossible), but some improvements over the current state would be awesome:

  • Press Esc (and maybe also q) to quit

    Currently it seems only Ctrl+C exits which is not intuitive.

  • Line numbers

  • Breadcrumb (e.g. path/to/file)

@samcoe samcoe added the enhancement New feature or request label Aug 26, 2021
@samcoe
Copy link
Owner

samcoe commented Aug 30, 2021

@kidonng Thanks for writing in. These are good ideas. Some of my thoughts on them:

  • Definitely agree that exiting on Esc makes sense. I would hold off on q though since the behavior would be inconsistent with which pane is in focus. Pressing q while searching for a file name should definitely not exit.

  • Line numbers would be great to have but a challenge to add. I investigated this a bit and would likely require major changes to the textview widget in rivo/tview.

  • Can you expand on the breadcrumbs idea a bit more? Would it just be a way to view the full file path at the top of the code viewing pane?

@mTvare6
Copy link

mTvare6 commented Sep 14, 2021

What about e for open in $EDITOR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants