Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This extends Figure related
options
for the Scroll component. Completing this allows implementers of Scroll to customize the canvas figures as required, giving more our less screen space to the figure, and provides flexibility on how the figure is rendered.Users can now customize:
options.figure.aspectRatio
default: 1.618 (golden ratio)options.figure.display
default: image-vieweroptions.figure.width
default: 38.2%As an enum, the other option for display is thumbnail.
How to Review?
npm run dev
demo.mdx
page atpages/docs/scroll/demo.mdx
, replacing Scroll JSX with: