Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to cancel batch #65

Open
sroosa opened this issue Nov 7, 2018 · 1 comment
Open

Ability to cancel batch #65

sroosa opened this issue Nov 7, 2018 · 1 comment
Labels

Comments

@sroosa
Copy link

sroosa commented Nov 7, 2018

Description:

As an ingester, I can cancel a batch I have initiated, so that I can save time if I realize a batch is failing hard

Does the cancel action stop where the batch is at, and items that have successfully completed are retained? Or should everything in the batch object, including items that were successful, be rolled back/deleted?

Done Looks Like:

  • Cancel batch button on the batch details page
  • Cancel batch button on the batch's line of the batch dashboard
  • Cancel batch buttons causes
    - request for confirmation from user
    - remaining items in the batch to become "cancelled"
    - currently running item continues to run
    - before starting to run another batch item, check status to see if it has been cancelled or is still enqueued; only run it if it is enqueued.
    - set the status for those batch item cancelled
    - sets the batch status to cancelled
@mcwhitaker
Copy link
Contributor

@sroosa Sadie, shouldn't the batch status be set to cancelled instead of failed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants