-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement-208] Add an option to send multiple times the same files #628
Conversation
This is an amazing PR!!! Thank you so much for contributing it. I will take some time to digest it, hopefully get to it this weekend. Generally looks great, I like the approach and design. Please ping me if I don't come back in a week. |
Looks like it doesn't build yet: src/cli/cli.go:307:97: not enough arguments in call to croc.GetFilesInfo
have ([]string, bool)
want ([]string, bool, bool) |
Hi @schollz, yeah I messed something up when I did the merge with main, I'll fix it right up. |
…enhancement_208
Ready for review:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just found some minor spelling mistakes 😊
Q: What is the purpose of the enhancement?
Q: What changed?
send
command have been added:multiple
andtimeout
(see README.md changes for their purpose).60 minutes
.main
andsecondary
.Main
rooms = the room used for the initial connection and communications between sender and receiversSecondary
rooms = alternative rooms used for file transfers only (the ones opened after the main connection is established successfully).Secondary
rooms are deleted after first use.Main
rooms are kept alive by the TCP server until their maximum number of transfers is achieved (successful or not). This is set with themultiple
flag. By default is1
.main
room and the sender is not busy the transfer commences.main
room and the sender is busy with a transfer, the receiver will enter a queue. There is no limit to how many can enter the queue, just in case some receivers decide to exit early.croc
andtcp
for easier understanding.tcp
.Q: Why sequential and not parallel transfers?