Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster.py list seems to hardcode 192.168.1.0/24 subnet? #22

Open
victorhooi opened this issue Oct 28, 2017 · 1 comment
Open

cluster.py list seems to hardcode 192.168.1.0/24 subnet? #22

victorhooi opened this issue Oct 28, 2017 · 1 comment

Comments

@victorhooi
Copy link

The cluster.py list command seems to assume you're using the 192.168.1.0/24 subnet?

c = 'nmap -sP 192.168.1.0/24'

    elif command == "list":
        print("scanning all ips...please wait")
        c = 'nmap -sP 192.168.1.0/24'
        r, code = run_command(c)
        logger.debug(r)
        logger.debug(code)
        lines = []
        for line in r.splitlines():
            if "scan report" in line:
                lines.append(line.split("for ")[1])
        r, code = run_command(c)
        for line in r.splitlines():
            if "scan report" in line:
                lines.append(line.split("for ")[1])
        print("\n".join(sorted(list(set(lines)))))
        return

Is this intentional?

@schollz
Copy link
Owner

schollz commented Oct 30, 2017

No, its based on my subnet which I thought would be similar for most cases so I left it in. It should be a variable though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants