Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Docker image #47

Open
aditisrinivas97 opened this issue Jan 21, 2019 · 5 comments
Open

Create a Docker image #47

aditisrinivas97 opened this issue Jan 21, 2019 · 5 comments

Comments

@aditisrinivas97
Copy link

aditisrinivas97 commented Jan 21, 2019

Create a docker image with all dependencies installed.

@schollz
Copy link
Owner

schollz commented Jan 21, 2019

@aditisrinivas97
Copy link
Author

aditisrinivas97 commented Jan 22, 2019

What is present here is just a Dockerfile which means every time someone builds, it will have to install everything. My suggestion was to build an image and push it to DockerHub where everyone can just pull the image having all the dependencies installed.

@schollz
Copy link
Owner

schollz commented Jan 22, 2019

Sounds good. I'm not the one to do this though because I don't have Mac OS.

@aditisrinivas97 aditisrinivas97 changed the title Create a multi-platform Docker image Create a Docker image Jan 27, 2019
@aditisrinivas97
Copy link
Author

aditisrinivas97 commented Jan 27, 2019

Hey, on second thoughts, all you need to do is publish the built image on Dockerhub. I can do it but if I do, I'll be the owner of the image. If you want me to do it, I can publish it and update the README. Let me know what works for you.

@kevholmes
Copy link

@schollz Hey - I just saw this issue and was thinking it could be implemented using a GitHub container repo combined with GitHub Actions. I could write an action that runs when you cut a release in GitHub with a semver. We could build the docker image in an Actions runner and push it out to the GitHub container repo with a tagged version. Then the public at large could pull from the ghcr.io repo if they're looking to use a container image, without having to deal with the build portion. LMK and I could get started on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants