-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Handle new numpy 2.0.dev string representation #210
Comments
Shall we do the easy thing with the legacy printoption, or you rather suggest to make a new directive that does this flexibly? (I suppose we need to do the printoption either way to fix the CI, but for downstream, it maybe useful to have a directive? Or should they all just update the reprs? cc @seberg |
I have mixed feeling about the new printout. This extra |
@pllim IDK how |
Re: WCS -- Maybe but it is just a small portion of things that would be similarly affected. For us downstream that don't see the point of extra stuff in printouts, this seems like busywork that we don't have time for. I think one of the WCS printout code is at https://github.com/astropy/astropy/blob/8ab8208a4df5c636054f07c763006324d245ddbd/astropy/wcs/wcs.py#L3116 |
But that said, I'll check out what Marten has worked out at astropy/astropy#15065 though so far he didn't touch WCS. |
There is a |
I thought we ignored it but it came back last night (https://github.com/scientific-python/pytest-doctestplus/actions/runs/5915248667/job/16041319959). So I took the liberty to relax the numpy-dev version check directly on main at 91104d8 since it is Sunday morning and I don't have much time. FYI. |
@pllim - I don't think it's necessary to push hot fixes like this, as 1) the failing cron only an effect in our internal testing 2) we still don't provide a solution for downstream. Besides, leaving an explicit dev version would be helpful while one is in the middle of the dev cycle. |
Example log: https://github.com/scientific-python/pytest-doctestplus/actions/runs/5704149430/job/15457469475
The text was updated successfully, but these errors were encountered: