Review all Jobs and reconcile with upstream changes

[jillpe]

Summary

Goal: Assess any changes to hyrax code versus files we find.

Roughly 10 files (5 bulkrax and 5 non-bulkrax)

Acceptance Criteria

• Jobs are for upstream changes

Screenshots or Video

Testing Instructions

Notes

[jillpe]

Blocked by:

• Upgrade to Hyrax 4.0 in new rails branch #22
• Rails Upgrade #23
• Create alternative docker compose / dockerfile to support upgrade rails version #24

[ShanaLMoore]

They will not be getting a bulkrax upgrade at this time.

there are no jobs overriding hyrax (per Rob).

[laritakr]

Bulkrax namespaced jobs:

using Bulkrax 1.0.2 branch gbh-patch hash 23efea3fd9d8d98746b73e570e0dc214ff764271

• ImporterJob:
  • overrides Bulkrax to add IndexAfterJob
  • Rescues RunTimeError with logger message
  • Remove IndexAfterJob but keep
• IndexAfterJob:
  • does a full nested reindex after the import is complete
  • Remove
• ImportWorkJob:
  • Override to retry Ldp::NotFound with 3 retries
  • Keep job
• DeleteWorkJob:
  • defines perform via class_eval
  • Also call AMS::AssetDestroyer when destroying a work that is an Asset
  • Keep job
• ChildRelationshipsJobDecorator:
  • Override to add a limit of 5 to the number of relationship job reschedules
  • Modifies work_membership method to raiseChildWorksError if not all children are found
  • Keep job

Hyrax namespaced jobs:

• CoolDigitalJob, CoolPhysicalJob, CoolEssenceJob:
  • Keep only if keeping Batch Ingest
  • Ref 🦄 Spike: Retest Hyrax-batch_ingest After Hyrax/Rails Upgrade #58 - Remove or test

Other jobs:

• ExportRecordsJob:
  • Keep
• PushToAapbJob:
  • Keep