Review all Actor overrides and reconcile with upstream changes

[jillpe]

Summary

Acceptance Criteria

• Actor overrides are reconciled with upstream changes

Screenshots or Video

Testing Instructions

Notes

[jillpe]

Blocked by:

• Upgrade to Hyrax 4.0 in new rails branch #22
• Rails Upgrade #23
• Create alternative docker compose / dockerfile to support upgrade rails version #24

[jillpe]

No longer blocked, as of 2023-08-10

[laritakr]

Actors

Custom Actors

• asset_actor.rb
• contribution_actor.rb
• digital_instantiation_actor.rb
• essence_track_actor.rb
• enforce_parent_title.rb
  • checks for parent_id param and force title to inherit from parent
• physical_instantiation_actor.rb
• update_asset_date.rb

Overridden Actors

• environment.rb
  • OVERRIDE Hyrax 2.9 to add in import flag (used in all of custom actors). Seems to be used to trigger the nested indexer.
• interpret_visibility_actor_decorator.rb
  • deal with fact that this class creates a brand new environment and does not pass any added arguments down to the new version. For importer flag compatibility

Summary

Conditionally remove env.curation_concern.reindex_extent

• Custom actors use env.curation_concern.reindex_extent = "queue#{env.importing.id}" if env.importing in queued_nesting_indexer.rb and nested indexing is obsolete.
• Both of the overridden actors are there to bring in the importer flag in order to support the nested indexing. There is no harm in keeping but they can be deleted during the cleanup of App.rails_5_1?
• Jobs, Actors, and Indexers are all affected.
• Unsure if any searches will break due to removing nested indexing... if so, after testing, may need to change to graph searches.