Review all Indexers overrides and reconcile with upstream changes

[jillpe]

Summary

Roughly 3 or 4 of these

Acceptance Criteria

• Indexers overrides are reconciled with upstream changes

Screenshots or Video

Testing Instructions

Notes

[jillpe]

Blocked by:

• Upgrade to Hyrax 4.0 in new rails branch #22
• Rails Upgrade #23
• Create alternative docker compose / dockerfile to support upgrade rails version #24

[jillpe]

No longer blocked, as of 2023-08-10

[ShanaLMoore]

INDEXERS

AMS/WorkIndexer

• #find_index_child_attributes => to index parent
• keep

AssetIndexer

• Inherits WorkIndexer
• keep

ContributionIndexer

• Inherits WorkIndexer
• keep

DigitalInstantiationIndexer

• Inherits WorkIndexer
• keep

EssenceTrackIndexer

• Inherits WorkIndexer
• keep

PhysicalInstantiationIndexer

• Inherits WorkIndexer
• keep

QueuedNestingIndexer

• Do we need to change this? Hyrax4 does not support Nested Indexing.
• It is currently wrapped in a conditional What functionality does this break in rails 6?

class QueuedNestingIndexer
  extend Samvera::NestingIndexer
  def self.reindex_relationships(id:, maximum_nesting_depth: nil, extent:)
    if extent.match("queue")
      Rails.logger.info("nested indexing queued")
      Redis.current.zadd("nested:index:#{extent.delete("queue")}", 0, id.to_s)
    else
      ::Samvera::NestingIndexer.reindex_relationships(id: id, extent: 'full')
    end
    true
  end
end

[ShanaLMoore]

TODO: test searches per @laritakr We may need to update search queries