Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract menus into their own module #170

Open
scionaltera opened this issue Sep 3, 2023 · 0 comments
Open

extract menus into their own module #170

scionaltera opened this issue Sep 3, 2023 · 0 comments
Labels
refactor Refactor of existing code

Comments

@scionaltera
Copy link
Owner

The menu code in the core module under com.agonyforge.mud.core.cli.menu.impl is a good candidate for refactoring into its own small module. It doesn't quite belong in the demo MUD because I don't want to make everybody implement their own menus from scratch if they don't want to. But it also doesn't quite belong in core because I'd expect most MUDs that get far enough along will want to customize how their menus look and not be forced to pull these default ones into their codebase. Having them in a separate module would walk that line pretty well: a sample implementation that can be added easily as a dependency for those who want it, and replaced for those who don't.

@scionaltera scionaltera added the good first issue Good for newcomers label Sep 3, 2023
@scionaltera scionaltera removed the good first issue Good for newcomers label Jan 19, 2024
@scionaltera scionaltera added enhancement New feature or request refactor Refactor of existing code and removed enhancement New feature or request labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor of existing code
Projects
None yet
Development

No branches or pull requests

1 participant