Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate exported nexus file. #24

Open
YooSunYoung opened this issue Feb 6, 2024 · 2 comments
Open

Validate exported nexus file. #24

YooSunYoung opened this issue Feb 6, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@YooSunYoung
Copy link
Member

essnmx should save reduced data as a nexus file for other analysis software.
This feature is done by #21 but it does not check if the nexus file is valid or not.
It should have a test or an option to check if the result file is valid or not.
Maybe chexus can be used here.

It has relatively simple structure, so it shouldn't be so difficult to implement.

@YooSunYoung YooSunYoung added enhancement New feature or request good first issue Good for newcomers labels Feb 6, 2024
@SimonHeybrock
Copy link
Member

Note that Chexus is not really checking for validity but for interpretability. It is also mainly targeted at raw data. So I am not sure it would be of much use. Maybe trying to load the file with relevant software would be a more suitable check?

@YooSunYoung
Copy link
Member Author

Yeah, Justin was doing it manually.

The next step is done by dials and it's not distributed on common channels,
like pip or conda as far as I understood.
And the software is >300 MB to download, so I thought it's not suitable for CI test...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants