Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for file output and side effects #55

Merged
merged 5 commits into from
Sep 12, 2023
Merged

Add recipe for file output and side effects #55

merged 5 commits into from
Sep 12, 2023

Conversation

jl-wynen
Copy link
Member

Fixes #29

Comment on lines 18 to 20
"from typing import NewType\n",
"\n",
"import sciline"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you imagine adding more recipes, we should make each stand-alone, i.e., move imports into the concrete example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured that these two are needed everywhere. But I can change it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but it makes it easier to copy-and-paste a working example if we repeat it. Or to split the page later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

docs/user-guide/recipes.ipynb Outdated Show resolved Hide resolved
"id": "d7608bb4-d7ce-4a36-8021-f1a52ad27ec5",
"metadata": {},
"source": [
"# Recipes"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a sibling of User Guide, so it can be reached more easily in fewer clicks?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be. We have limited real estate in the top bar. Do you think this is important / commonly used enough?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so, yes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

docs/user-guide/recipes.ipynb Outdated Show resolved Hide resolved
@jl-wynen
Copy link
Member Author

What do you think of the name 'Recipes'? What about 'Examples', 'How to', or something similar. This is the best time to change it...

@SimonHeybrock
Copy link
Member

SimonHeybrock commented Sep 12, 2023

What do you think of the name 'Recipes'? What about 'Examples', 'How to', or something similar. This is the best time to change it...

Recipes is good. Or "Recipes and Examples"? How to sounds good as well :)

@jl-wynen
Copy link
Member Author

I left it as recipes because that is short and the header is short, too.

@jl-wynen jl-wynen merged commit 7547f70 into main Sep 12, 2023
5 checks passed
@jl-wynen jl-wynen deleted the fileio-docs branch September 12, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling file save or upload operations
2 participants