Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch backend controller tests to request tests #115

Open
scottohara opened this issue Jul 13, 2016 · 1 comment
Open

Switch backend controller tests to request tests #115

scottohara opened this issue Jul 13, 2016 · 1 comment

Comments

@scottohara
Copy link
Owner

(from http://rspec.info/blog/2016/07/rspec-3-5-has-been-released/)

For new Rails apps: we don't recommend adding the rails-controller-testing gem to your application. The official recommendation of the Rails team and the RSpec core team is to write request specs instead. Request specs allow you to focus on a single controller action, but unlike controller tests involve the router, the middleware stack, and both rack requests and responses. This adds realism to the test that you are writing, and helps avoid many of the issues that are common in controller specs. In Rails 5, request specs are significantly faster than either request or controller specs were in rails 4, thanks to the work by Eileen Uchitelle1 of the Rails Committer Team.

@scottohara
Copy link
Owner Author

Could be done as part of #139?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant