Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add :exat and :pxat keywords to #set method #279

Closed
jcagarcia opened this issue Oct 13, 2023 · 1 comment
Closed

Add :exat and :pxat keywords to #set method #279

jcagarcia opened this issue Oct 13, 2023 · 1 comment
Labels
enhancement

Comments

@jcagarcia
Copy link
Contributor

The #set method has a :exat and :pxat keywords to set the expiration time in Unix time format in seconds and milliseconds (see https://www.rubydoc.info/gems/redis/Redis/Commands/Strings#set-instance_method). MockRedis is returning an ArgumentError: unknown keyword: :exat when using that keyword.
@jcagarcia jcagarcia mentioned this issue Oct 13, 2023
Merged
sds pushed a commit that referenced this issue Oct 25, 2023
@jcagarcia
feat(set_exat_pxat): Add EXAT and PXAT arguments to the SET redis com…
eb1e5dd 
…mand (#280)

Related with this issue #279 

* Documentation for the feature here: https://redis.io/commands/set/
* Added tests for SET ... EXAT and PXAT on a valid and invalid key

Hope you find it useful 😄
@sds
Copy link
Owner

sds commented Oct 25, 2023

Implemented in #280. Thank you.

@sds sds closed this as completed Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sds @jcagarcia