Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for referencing commands from another patch in a patch definition #26

Open
sean-e opened this issue Apr 18, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@sean-e
Copy link
Owner

sean-e commented Apr 18, 2023

In the following patch definitions, the hex string used in the momentary patch command duplicates the same strings already defined, since there is no way to refer to the commands of another patch:

<patch name="Delay 1 Hold" device="Axe-Fx" type="toggle" >
	<midiByteString name="A">F0 00 01 74 10 01 09 00 46 00 1B 00 00 00 00 00 04 00 00 44 F7</midiByteString>
</patch>
<patch name="Delay 1 no repeat" device="Axe-Fx" type="toggle" >
	<midiByteString name="A">F0 00 01 74 10 01 09 00 46 00 1B 00 00 00 00 00 00 00 00 40 F7</midiByteString>
</patch>
<patch name="Delay 1 Hold (mom)" device="Axe-Fx" type="momentary" >
	<midiByteString name="A">F0 00 01 74 10 01 09 00 46 00 1B 00 00 00 00 00 04 00 00 44 F7</midiByteString>
	<midiByteString name="B">F0 00 01 74 10 01 09 00 46 00 1B 00 00 00 00 00 00 00 00 40 F7</midiByteString>
</patch>

A workaround for a composite toggle uses the PatchListSequence patch type:

<patch name="Delay 1 Hold (tgl)" device="Axe-Fx" type="patchListSequence" gaplessRestart="1" initialStep="1" >
	<patchListItemName>Delay 1 no repeat</patchListItemName>
	<patchListItemName>Delay 1 Hold</patchListItemName>
</patch>

but it's really just a hack for the same issue. The same hack doesn't make sense for a momentary use.

@sean-e sean-e added the enhancement New feature or request label Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant