Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug, IJ1: contours and ROI manager #13

Open
xulman opened this issue Mar 20, 2024 · 2 comments
Open

bug, IJ1: contours and ROI manager #13

xulman opened this issue Mar 20, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@xulman
Copy link
Contributor

xulman commented Mar 20, 2024

reported originally outside:

  1. Problem when closing the RoiManager
  2. When uncheck “Add to Roi” SAMJ doesn’t generate a outline of the segmentation

The issue with the latter is that contours are driven through the ROI manager, so if one disables adding new contours into the manager, the new ones don't get displayed... we have to explicitly draw them via IJ1 API (non ROI manager API).

@xulman xulman added the bug Something isn't working label Mar 20, 2024
@carlosuc3m
Copy link
Contributor

Hello @xulman I already implemented a fast temporal fix (roi manager cannot be unchecked lol).

I think this issue is a little bit deeper and that we need to figure out what behaviour we actually want from the ROI manager, because now it is really not defined.

@xulman
Copy link
Contributor Author

xulman commented Mar 20, 2024

I think this issue is a little bit deeper and that we need to figure out what behaviour we actually want from the ROI manager, because now it is really not defined.

yes, we especially need to think outside ROI manager and IJ1 prompts, not always one would want to interact with SAMJ via these (consider BigDataViewer as an gui interface, the macro scripts, etc..). For BDV, for example, we would probably need to come up with an own dialog that reviews the current segmentation countours -- maybe we would use it for IJ1 too... as the functionality/possibilities of ROI manager is not exactly matching SAMJ (which is another source of confusion for users)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants