Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retnzestimate? #28

Open
nitrocode opened this issue Apr 4, 2018 · 17 comments
Open

retnzestimate? #28

nitrocode opened this issue Apr 4, 2018 · 17 comments

Comments

@nitrocode
Copy link

Noticed this misspelling in a few places and it might be setting the wrong flag in GetSearchResults() and GetZEstimate() functions

https://github.com/seme0021/python-zillow/blob/master/zillow/api.py#L55
@nitrocode
Copy link
Author

@bhoscheit I don't think spamming all the issues is the best way to get help

@RyanConway91
Copy link

Any updates on this? I am trying to get rent estimates for properties which I know have them (can view them through the zillow app) but cannot seem to get this information from the API wrapper. Any idea how to fix this? I am assuming the "retnzestimate"typo is part of the issue, as with "retnzestimate" you would not be accessing the "rentzestimate" property of API. I fixed these typos in the code I downloaded but still not getting the results.

@bhoscheit
Copy link

bhoscheit commented Mar 31, 2019 via email

@RyanConway91
Copy link

Hey Ben, got it working! Found the updated code and it is working now. What do you mean "project"?

Thanks

@bhoscheit
Copy link

bhoscheit commented Mar 31, 2019 via email

@RyanConway91
Copy link

Oh okay I thought maybe "project" that was github lingo for something. I am trying automate an realestate investment calculator for the Minneapolis area.

@bhoscheit
Copy link

bhoscheit commented Mar 31, 2019 via email

@RyanConway91
Copy link

Thanks!

@RyanConway91
Copy link

RyanConway91 commented Jun 28, 2019 via email

@pmdbt
Copy link

pmdbt commented Feb 21, 2020 •
edited
Loading

@RyanConway91 Hey Ryan, thanks for putting this repo together. I followed your code here:

api = zillow.ValuationApi()
        data = api.GetDeepSearchResults(key, address, postal_code,rentzestimate = True)
        data_dict = data.get_dict()
        bdrms = data_dict['extended_data']['bedrooms']
        bthrms = data_dict['extended_data']['bathrooms']
        sqft = data_dict['extended_data']['bathrooms']
        lot_sqft = data_dict['extended_data']['lot_size_sqft']
        tax_ass = float(data_dict['extended_data']['tax_assessment'])
        tax_rate = 1.81/100
        tax = tax_ass*tax_rate

        rent_zest = data_dict['rentzestimate']['amount']
        rent_zest_high = data_dict['rentzestimate']['valuation_range_high']
        rent_zest_low = data_dict['rentzestimate']['valuation_range_low']

However, I was getting an error:

TypeError: GetDeepSearchResults( ) got an unexpected keyword argument 'rentzestimate'

So, I looked at your source code and it appears you've made a syntax/spelling error on this line:

def GetDeepSearchResults(self, zws_id, address, citystatezip, retnzestimate=False):

You spelled rentzestimate as retnzestimate. The method "GetSearchResult()" has the same typo as well. Thought you should know and make a quick update :). I'm using version 0.2.0 for reference.

@nitrocode pointed this out in his original comment as well, but it doesn't appear to be fixed everywhere.

@jecronin
Copy link

jecronin commented Jun 26, 2020 •
edited
Loading

@RyanConway91 circling back on @nitrocode and @pmdbt's notes. How is the spelling issue affecting the ability to pull in rentzestimate from the API? For example, if you go to this URL the rentzestimate is displayed in the XML but it is not when you call the Valuation API in python. The rent zestimate with the price would be great to do ROI calcs at scale for a batch of properties, all within python Thank you for your help!

https://www.zillow.com/webservice/GetSearchResults.htm?zws-id=X1-ZWz1h9tnvngv7v_31kch&address=11820+Melones+Circle&citystatezip=Gold+River%2c+CA&rentzestimate=True

image

@nitrocode
Copy link
Author

nitrocode commented Jun 26, 2020 •
edited
Loading

It might be time to fork this repo or use another zillow package or another realestate api package

@pmdbt
Copy link

pmdbt commented Jun 26, 2020 via email

@RyanConway91
Copy link

RyanConway91 commented Jun 27, 2020 via email

@jecronin
Copy link

@pmdbt that would be great thank you! Sidebar: I talked to Max awhile back and he took me through Lofty. Amazing product, awesome work

@jecronin
Copy link

@RyanConway91, I've submitted a pull request to update the retnzestimate typos to rentzestimate. Thank you for your help!

@thaskef
Copy link

thaskef commented Jan 11, 2021

It would be amazing if we can get the rent estimate fixed. As is, everything works in a Google Colab notebook except for that. I wish someone could help so I don't have to go back and redo it all on a local machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@nitrocode @bhoscheit @RyanConway91 @pmdbt @jecronin @thaskef