Allow inheritance of monitored and benchmarked
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nchmarked and monitored status; this enables you to set those once on an ApplicationJob class that all of your actual job classes descend from
|
I will test it and merge it asap. Thank you for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We like to establish a high level
ApplicationJobin our apps that actual work-processing jobs can inherit from. To enable that, this pull request switches to using acattr_readerto handle tracking of benchmark & monitor status so that we can declare those once on theApplicationJob.(tests fail both on master and on this PR, but we're using this on a real app with results as expected)