Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoDiameter fails if hole is too large #381

Open
Roy-043 opened this issue May 21, 2024 · 2 comments
Open

AutoDiameter fails if hole is too large #381

Roy-043 opened this issue May 21, 2024 · 2 comments

Comments

@Roy-043
Copy link
Contributor

Roy-043 commented May 21, 2024

  1. Create a hole with a diameter of 100mm (users can do strange things... 😉)
  2. Select the circular edge.
  3. Insert a fastener, for example DIN571.
  4. Result: Error message see below.
21:53:37  pyException: Traceback (most recent call last):
  File "C:\Users\Name\AppData\Roaming\FreeCAD\Mod\fasteners\.\FastenersCmd.py", line 669, in execute
    self.calc_diam = screwMaker.AutoDiameter(
                     ^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Name\AppData\Roaming\FreeCAD\Mod\fasteners\.\ScrewMaker.py", line 487, in AutoDiameter
    return res
           ^^^
<class 'UnboundLocalError'>: cannot access local variable 'res' where it is not associated with a value
21:53:37  Screw: cannot access local variable 'res' where it is not associated with a value
@shaise
Copy link
Owner

shaise commented May 22, 2024

Thanks! I'll take a look.

@shaise
Copy link
Owner

shaise commented May 24, 2024

Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants