Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changine size of fastener results in error #393

Open
Sil68 opened this issue Jun 26, 2024 · 2 comments
Open

Changine size of fastener results in error #393

Sil68 opened this issue Jun 26, 2024 · 2 comments

Comments

@Sil68
Copy link

Sil68 commented Jun 26, 2024

When trying to change the size of a fastener ('change fastener parameter', 'set size') I am always receiving an error message:

At /Users/user/Library/Application Support/FreeCAD/Mod/fasteners/./FSChangeParams.py Line 384
08:06:06  At /Users/user/Library/Application Support/FreeCAD/Mod/fasteners/./ScrewMaker.py Line 397
08:06:06  At /Users/user/Library/Application Support/FreeCAD/Mod/fasteners/./FastenerBase.py Line 280
08:06:06  argument of type 'float' is not iterable: Inappropriate argument type.

I have tried this both on Debian Linux as well as on MacOS, rendering the very same results.

OS: macOS 14.6
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.37573 (Git)
Build type: Release
Branch: main
Python 3.11.9, Qt 5.15.13, Coin 4.0.2, Vtk 9.2.6, OCC 7.7.2
Locale: C/Default (C)
Installed mods: 
  * MeshRemodel 1.9.23
  * ThreadProfile 1.90.0
  * Reporting
  * btl 0.9.9
  * BillOfMaterials 0.0.8.5
  * freecad.gears 1.2.0
  * woodworking 0.21.2.33771
  * OpenTheme 2024.5.16
  * Defeaturing 1.2.2
  * Gridfinity 0.5.0
  * FEMbyGEN 2.1.0
  * QuickMeasure 2022.10.28
  * fasteners 0.5.23
  * lattice2 1.0.0
  * Estimate 0.1.2
  * Design456 0.0.1
  * WB_Organizer 2024.1.29
  * sheetmetal 0.4.18
  * FEM_FrontISTR 0.1.0
  * 3D_Printing_Tools
  * Curves 0.6.39
  * Assembly4 0.50.13
@valpackett
Copy link

Just hit this as well. As a quick fix, FSChangeParams.py Line 384:

                                d, l, w = screwMaker.FindClosest(

and in ScrewMaker.py

        # auto find width, if applicable
        if width is not None:
            width = str(width) # <<<<<<< add this
            width_table = FsData[type + "width"][diam]
        # auto find length
        len = str(len) # <<<<<<< add this
        lens = self.GetAllLengths(type, diam, False, width)
        origlen = FastenerBase.LenStr2Num(len)

@shaise
Copy link
Owner

shaise commented Aug 31, 2024

@valpackett thanks!
@Sil68 , it should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants