Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extruded Cutout Incorrect work #401

Open
free777cat opened this issue Nov 20, 2024 · 5 comments
Open

Extruded Cutout Incorrect work #401

free777cat opened this issue Nov 20, 2024 · 5 comments
Assignees
Labels

Comments

@free777cat
Copy link

Describe your issue

 Extruded Cutout    Incorrect work

FreeCAD version info + SheetMetal WB version

[code]
OS: Linux Mint 22 (MATE/mate)
Word size of FreeCAD: 64-bit
Version: 2024.1006.0.14555 (Git shallow) AppImage
Build type: Release
Branch: (HEAD detached at 20241003stable)
Hash: 8058dcf52c2661edabf36d8147d5b8a187378d2d
Python 3.11.9, Qt 5.15.13, Coin 4.0.1, Vtk 9.2.6, OCC 7.7.2
Locale: Ukrainian/Ukraine (uk_UA)
Installed mods: 


  * sheetmetal 0.5.6

[/code]

Put here any screenshots or videos (optional)

Incorrect_work.zip
Зняток екрана як 2024-11-20 10-39-43

@shaise
Copy link
Owner

shaise commented Nov 20, 2024

@sheetmetalman , can you take a look?

@sheetmetalman
Copy link
Contributor

Yes! As soon as possible.

@sheetmetalman
Copy link
Contributor

Hi!

As I understood, the problem is that the result geometry is entering the sketch extrusion zone, as show in the image below.
But the correct geometry should be the second image.

image
image

Looking other software (SolidWorks) at how they deal with, I find they have the same issue, BUT they implement a function to resolve this. Solidworks calls it "Optimize geometry". The below images and video show what happen in this case in SolidWorks.

image
image
image
image

From where I take the pictures above: https://www.youtube.com/watch?v=_VdK-DPmJQo and https://www.javelin-tech.com/blog/2017/01/solidworks-2017-normal-cut-optimize-geometry/

I implement the same thing. Theres gonna have a property where the user set to true for "improve cut". But I also add another property to set the quality of this cut geometry improvement, as show in the video and the images below.

improvecut.mp4

image

This function need improvements yet. Next step is to find a way to smooth the edges before the cut operation in the code.

@luzpaz
Copy link
Collaborator

luzpaz commented Nov 27, 2024

Version: 2024.1006.0.14555 (Git shallow) AppImage

An aside, @free777cat where did you install this version of FreeCAD from ?

@free777cat
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants