FonDevs - Incorrect Struct encoding will cause valid signatures to fail

[sherlock-admin2]

FonDevs

High

Incorrect Struct encoding will cause valid signatures to fail

https://github.com/sherlock-audit/2024-11-vvv-exchange-update/blob/main/vvv-platform-smart-contracts/contracts/vc/VVVVCTokenDistributor.sol#L157C5-L174C11

Summary

The contract VVVVCTokenDistributor fails to implement the struct encoding correctly according to EIP712.
The EIP states that The array values are encoded as the keccak256 hash of the concatenated encodeData of their contents.
instead the contract just encodes the whole array instead of also encoding each of the individual elements in the array.

check this link for a reference https://ethereum.stackexchange.com/questions/151513/eip712-typeddata-encoding-with-nested-array-of-structs-returning-wrong-signer

Root Cause

Wrong data encoding

Internal pre-conditions

No response

External pre-conditions

No response

Attack Path

No response

Impact

it will not be possible to claim token with that contract

PoC

No response

Mitigation

No response