smbv-1923 - Contracts doesn't work with Polkadot chain

[sherlock-admin2]

smbv-1923

High

Contracts doesn't work with Polkadot chain

Summary

VVVVCInvestmentLedger.sol and VVVVCTokenDistributor.sol will not work with Polkadot chain

Root Cause

VVV-Exchange supports Eth, base, bnb, avalanche, polkadot, arbitrum ,not only EVM.
Non And non EVM chains can have a different address standard like Polkadot.
https://github.com/sherlock-audit/2024-11-vvv-exchange-update/blob/main/vvv-platform-smart-contracts/contracts/vc/VVVVCTokenDistributor.sol#L166

Internal pre-conditions

VVV-Exchange supports Polkadot chain

External pre-conditions

No response

Attack Path

• This contract doesn't support Polkadot chain(non-EVM)
• Address datatype doesn't get support in POLKADOT chain. Address is being represented as string variable in polkadot chain.
• Due to which contracts will not work on POLKADOT chain.
• Difference between Polkadot and Ethereum chain
  • Ethereum standard is 20-bytes-long AccountId and ECDSA secp256k1 key pairs in combination with keccak256 hash function
  • Normally in Polkadot we use 32-bytes-long AccountId accompanied with Schnorrkel/Ristretto sr25519 algorithm for keys and signing, and blake2 for hashing.
• As address is represented as string datatype, the contract would fail in multiple scenario's wherever address is being used.
• Resources - https://forum.polkadot.network/t/ethereum-rpc-compatibility-for-polkadot-smart-contracts/7375#:~:text=chain%2Dspecific%20data.-,Chain%20Layer,-Here%20it%20comes
• https://solodit.cyfrin.io/issues/m-09-interchainproposalexecutorsol-doesnt-support-non-evm-address-as-caller-or-sender-code4rena-axelar-network-axelar-network-git

Impact

Contract doesn't work on Polkadot chain

PoC

No response

Mitigation

• Should make different contract with changes required like converting address to string datatype.