Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Size.Zero deleted in 4.9 causing code breaking #1640

Open
sdcb opened this issue Jan 11, 2024 · 2 comments · May be fixed by #1641
Open

Size.Zero deleted in 4.9 causing code breaking #1640

sdcb opened this issue Jan 11, 2024 · 2 comments · May be fixed by #1641

Comments

@sdcb
Copy link

sdcb commented Jan 11, 2024 •
edited
Loading

Size.Zero deleted in 4.9, cause code breaking, the workaround is replace Size.Zero into default, it might not make sense to me.

We should add back OpenCvSharp.Size.Zero
This was referenced Jan 11, 2024
Closed
Merged
Open
@shimat
Copy link
Owner

shimat commented Jan 11, 2024

Size.Zero was introduced a long time ago to be compatible with System.Drawing.Size.Empty, since there was no default(T) in C# 1.0. But now I think default can satisfy all our needs. Lately I have been focusing on reducing code size as much as possible and do not want to make this change.

@Jiangmitiaotiao
Copy link

"Version 2.7.0.3 of Sdcb.PaddleOCR and version 4.10 of OpenCvSharp still throw an exception System.MissingFieldException: 'Cannot find field: OpenCvSharp.Size.Zero'."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add back Zero into Size.cs sdcb/opencvsharp
3 participants
@sdcb @shimat @Jiangmitiaotiao