Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose PHPUnit src for Psalm analyse #504

Closed
1 task done
ro0NL opened this issue Sep 21, 2021 · 2 comments
Closed
1 task done

Expose PHPUnit src for Psalm analyse #504

ro0NL opened this issue Sep 21, 2021 · 2 comments
Assignees
@shivammathur
Labels
enhancement New feature or request

Comments

@ro0NL
Copy link

ro0NL commented Sep 21, 2021 •
edited
Loading

Describe the feature
Expose PHPUnit src files extracted from PHAR.

Version

  • I have checked releases, and the feature is missing in the latest patch version of v2.

Underlying issue
Psalm can't follow PHARs out-of-the-box: vimeo/psalm#3868

Describe alternatives

phar extract -f "$(which phpunit)" var/phpunit-src

Additional context
Having this extracted files saves us a step 👼

Are you willing to submit a PR?

Let's see :)
@ro0NL ro0NL added the enhancement New feature or request label Sep 21, 2021
@shivammathur
Copy link
Owner 

tools: phpunit/phpunit, psalm

This would set up PHPUnit using composer globally and psalm as phar, then one can add ~/.composer/vendor/phpunit/phpunit to extraFiles.

@ro0NL
Copy link
Author

ro0NL commented Sep 21, 2021

The world is not ready for PHARs, yet :D

A global composer install sounds reasonable for CI 👍

Nice work here overall :)

@ro0NL ro0NL closed this as completed Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivammathur shivammathur

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ro0NL @shivammathur