Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd waveform discrepancy in TestJunoPatch.wav #116

Open
dpwe opened this issue Apr 17, 2024 · 0 comments
Open

Odd waveform discrepancy in TestJunoPatch.wav #116

dpwe opened this issue Apr 17, 2024 · 0 comments

Comments

@dpwe
Copy link
Collaborator

dpwe commented Apr 17, 2024

test.py:TestJunoPatch plays a 4-note chord using the Juno patch 20, loaded with voices='0,1,2,3', load_patch=20. We've recently made some changes in how a complex patch like that is set up and rendered. Today, I used my compare_test_wavs.ipynb to examine why the test was giving such a relatively large error relative to the reference wav (-36.7 dB error for a -20 dB signal).

Here are the plots of the reference (from April 14) and current waveform outputs, and the difference between them:
download-2
download-1

To listen to them, they are hard to distinguish. However, there's clearly a systematic difference in the waveform that seems to be following some kind of 3 Hz triangle shape with an amplitude tending to a multiple of ~600 units.

I'm thinking it's either the LFO being added to the output (unlikely), or something with the chorus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant