-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APNG not supported #79
Comments
I do plan to implement support for APNG files in Oxipng, however at the moment it is low priority so I can't give a timeframe on when it will be implemented. |
Thanks. |
N.B.: 1st work on this is @ db0131c |
I just wanted to reassure everyone that I am still working on this issue. I have had less time lately to focus on open source, but I have not abandoned this project. |
Glasd to hear @shssoichiro |
Unfortunately this is soft-blocked on image-rs/image#195. The code in oxipng can still be written, but there would be no sanity check on optimized images to make sure oxipng hasn't corrupted them, and no automated tests. I don't feel comfortable delivering this functionality until its correctness can be verified. |
APNG support was added in image-rs/image#1250, so it's now possible to resume development of this feature. |
Any progress on this? |
@shssoichiro, @andrews05: Sorry for tagging y'all directly 🙇🏾♂️, but minimal support seems so close. If y'all could spare a few minutes & let us know whether this is a reasonable idea, we'd appreciate it.:
Is it possible, in the interim, to have some way of protecting just these chunks? IIUC, that would salvage APNGs enough that they could be otherwised optimized by OxiPNG, until full support can be finalized. |
@andrews05 Thanks very much 🙇🏾♂️ |
@TPS Turns out this isn't quite so simple. The APNG fdAT chunks use the same depth, colour type, palette, interlacing, etc as the main image. If those values are changed at all during optimisation, the fdATs would then be invalid. So it isn't just a matter of preserving those chunks, you would also have to disable all reductions. |
We really appreciate you taking the time to research & explain this, @andrews05 🙇🏾♂️ |
#551 tracks Full aPNG Optimization. |
With old OptiPNG I could use -protect acTL,fcTL,fdAT to keep APNG animations. But seems it is not possible with OxiPNG.
Find attached example.
Will you support it?
The text was updated successfully, but these errors were encountered: