Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to a containerized protoc for generated code #817

Open
haydentherapper opened this issue Oct 7, 2022 · 2 comments
Open

Switch to a containerized protoc for generated code #817

haydentherapper opened this issue Oct 7, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@haydentherapper
Copy link
Contributor

Description

See https://github.com/namely/docker-protoc

This solves the issue of a mismatch between the locally installed protoc and the one used to check for updated generated code in the GHA workflow.

@haydentherapper haydentherapper added the enhancement New feature or request label Oct 7, 2022
bailey-coding pushed a commit to bailey-coding/fulcio that referenced this issue Oct 23, 2022
Closes sigstore#817

(This causes changes, but if we pinned versions it wouldn't, once we update everywhere to use the same image/versions)
@bailey-coding
Copy link

Generating the protobuf clients with namely/protoc-all latest has some changes, which are probably somewhat expected, with the different versions of the various libraries.

I think it's because they update a few different things, and don't tag with protoc versions or other ones, but their own versions, but if we moved all uses to their version, at least we could use that consistently.

Here is the generated diff - https://gist.github.com/justbaileym/b9768410743c779fa2e3adb342478da5

I'm sure there are other places I need to update things in my branch, and my changes to the Makefile magic seem a bit janky

@haydentherapper
Copy link
Contributor Author

Thanks for taking a look at this! Only concern is some of the swagger doc updates, though we saw something similar in #835, but I haven't had a chance to dig much into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants