Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it hard to accidentally not have a CT log #891

Open
znewman01 opened this issue Nov 16, 2022 · 4 comments
Open

Make it hard to accidentally not have a CT log #891

znewman01 opened this issue Nov 16, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@znewman01
Copy link
Contributor

Right now, if --ct-log-url is not passed, we don't set up the CT log:

if logURL := viper.GetString("ct-log-url"); logURL != "" {

That feels easy to do accidentally. Should we require a --no-ct-log flag for testing or other environments without a CT log?

H/T @mnm678 and her student (whose GH I don't know)

@znewman01 znewman01 added the bug Something isn't working label Nov 16, 2022
@haydentherapper
Copy link
Contributor

Sounds reasonable to me! Note, if in a private deployment you're using both Rekor and Fulcio, then you could avoid the need for a CT log if you leverage Rekor as a CT log.

@mnm678
Copy link

mnm678 commented Nov 17, 2022

cc @Junochiu

@federico-falconieri-form3

Sounds reasonable to me! Note, if in a private deployment you're using both Rekor and Fulcio, then you could avoid the need for a CT log if you leverage Rekor as a CT log.

@haydentherapper could you please elaborate further? Is there any documentation on how to use rekor as a ctlog? From the scaffold chart & docs I understood that ctlog is an entirely separate, necessary component from rekor

@haydentherapper
Copy link
Contributor

This is a discussion on trust boundaries - If your log and certificate authority operate in the same trust domain (as in, if one gets compromised, the other is likely to also), then there's little value in operating a second log. However, note that the CT log and Rekor record different things - CT records issued certificates, Rekor records signing events. You could skip putting certificates into the CT log as long as you always are putting signing events into Rekor. Then an identity monitor only needs to monitor Rekor, not a CT log too.

As for how to set this up in scaffold, you can ask on our slack #private-sigstore-users channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants