Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every failed request is logged as an error #908

Open
haydentherapper opened this issue Dec 7, 2022 · 1 comment
Open

Every failed request is logged as an error #908

haydentherapper opened this issue Dec 7, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@haydentherapper
Copy link
Contributor

See https://github.com/sigstore/fulcio/blob/main/pkg/server/error.go#L42, all request errors are logged as errors regardless of if it's due to the user (4xx) or server (429, 5xx). This leads to a lot of errors in the logs that are due to malformed JWTs.

We should differentiate between user errors and server errors. User errors should be at most WARN, but for JWT errors, I would remove logging entirely since there's nothing actionable to do.

@haydentherapper haydentherapper added the bug Something isn't working label Dec 7, 2022
@haydentherapper
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant