Policy Controller does not support deployment strategy values #748
Labels
enhancement
New feature or request
Comments
shearn89
added a commit
to shearn89/helm-charts
that referenced
this issue
May 7, 2024
Prior to this change, the policy controller webhook was not able to have its deployment strategy modified. If you only deployed a single replica, it could not perform a rolling update due to the default `maxSurge: 25%` being rounded down to 0. This change exposes those values, so that the `maxSurge` can be updated and a single instance can be rolled. Fixes sigstore#748.
4 tasks
shearn89
added a commit
to shearn89/helm-charts
that referenced
this issue
May 7, 2024
Prior to this change, the policy controller webhook was not able to have its deployment strategy modified. If you only deployed a single replica, it could not perform a rolling update due to the default `maxSurge: 25%` being rounded down to 0. This change exposes those values, so that the `maxSurge` can be updated and a single instance can be rolled. Fixes sigstore#748. Signed-off-by: Alex Shearn <[email protected]>
shearn89
added a commit
to shearn89/helm-charts
that referenced
this issue
May 8, 2024
Prior to this change, the policy controller webhook was not able to have its deployment strategy modified. If you only deployed a single replica, it could not perform a rolling update due to the default `maxSurge: 25%` being rounded down to 0. This change exposes those values, so that the `maxSurge` can be updated and a single instance can be rolled. Fixes sigstore#748. Signed-off-by: Alex Shearn <[email protected]>
shearn89
added a commit
to shearn89/helm-charts
that referenced
this issue
Oct 10, 2024
Prior to this change, the policy controller webhook was not able to have its deployment strategy modified. If you only deployed a single replica, it could not perform a rolling update due to the default `maxSurge: 25%` being rounded down to 0. This change exposes those values, so that the `maxSurge` can be updated and a single instance can be rolled. Fixes sigstore#748. Signed-off-by: Alex Shearn <[email protected]>
shearn89
added a commit
to shearn89/helm-charts
that referenced
this issue
Dec 12, 2024
Prior to this change, the policy controller webhook was not able to have its deployment strategy modified. If you only deployed a single replica, it could not perform a rolling update due to the default `maxSurge: 25%` being rounded down to 0. This change exposes those values, so that the `maxSurge` can be updated and a single instance can be rolled. Fixes sigstore#748. Signed-off-by: Alex Shearn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Looking at the charts for the
policy-controllerwebhook, it does not seem possible to pass in values for the deployment strategy. Specifically things likemaxSurge?My actual problem:
I'm unable to drain a node because I've got
policy-controllerdeployed withreplicas: 1, and the default deployment strategy won't let it surge to 2 in order to roll, because themaxSurgedefaults to 25% rounded down, i.e. 0.What I'd like to do:
The text was updated successfully, but these errors were encountered: