Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalizationManagerTests.GetDynamicStringOrEnglish fails without side effects of test #60

Open
ermshiperete opened this issue Apr 30, 2019 · 0 comments

Comments

@ermshiperete
Copy link
Member

The comments for GetDynamicStringOrEnglish test method suggests that the string given as parameter should always win. This is tested with four assertions for different cases.

However, the first case where we ask for "en" modifies the xliff data structure. This causes the second test where we ask for "ar" to pass because when we ask for the fallback the modified string from the first test gets returned.

If the first assert gets commented out the test fails, suggesting that the implementation doesn't do what the method tries to test.

@ermshiperete ermshiperete changed the title LocalizationManagerTests.GetDynamicStringOrEnglish fails without of side effects of test LocalizationManagerTests.GetDynamicStringOrEnglish fails without side effects of test Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant