You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The comments for GetDynamicStringOrEnglish test method suggests that the string given as parameter should always win. This is tested with four assertions for different cases.
However, the first case where we ask for "en" modifies the xliff data structure. This causes the second test where we ask for "ar" to pass because when we ask for the fallback the modified string from the first test gets returned.
If the first assert gets commented out the test fails, suggesting that the implementation doesn't do what the method tries to test.
The text was updated successfully, but these errors were encountered:
ermshiperete
changed the title
LocalizationManagerTests.GetDynamicStringOrEnglish fails without of side effects of testLocalizationManagerTests.GetDynamicStringOrEnglish fails without side effects of test
Apr 30, 2019
The comments for
GetDynamicStringOrEnglish
test method suggests that the string given as parameter should always win. This is tested with four assertions for different cases.However, the first case where we ask for "en" modifies the xliff data structure. This causes the second test where we ask for "ar" to pass because when we ask for the fallback the modified string from the first test gets returned.
If the first assert gets commented out the test fails, suggesting that the implementation doesn't do what the method tries to test.
The text was updated successfully, but these errors were encountered: