Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix top section on mobile #3

Open
scamille opened this issue Sep 10, 2020 · 5 comments · Fixed by #4
Open

Fix top section on mobile #3

scamille opened this issue Sep 10, 2020 · 5 comments · Fixed by #4

Comments

@scamille
Copy link
Member

See screenshot. The menu as well as the text need to be better aligned.

Screenshot_20200910-082540

@scamille scamille changed the title Fix too section on mobile Fix top section on mobile Sep 10, 2020
@scamille
Copy link
Member Author

With shadowlands

Screenshot_20200920-093423

@scamille
Copy link
Member Author

scamille commented Oct 2, 2020

Looks different now with the logo not getting too large.

The 2 sections on the right, with the menu and text are still not in sync tough.
Screenshot_20201002-071231

@apstone
Copy link
Contributor

apstone commented Oct 2, 2020

I think there are a number of mobile issues, if I get some time tonight I will submit another PR @scamille

With the image overflowing out of its container, would it be better to just increase its container size to maintain a larger image?

@Bloodmallet
Copy link
Member

Is this still an issue or are you content with the latest version?

@scamille
Copy link
Member Author

scamille commented Jul 1, 2021

This is still a problem. I think I had to revert parts of the PR created to solve this because it made other behavior of the header worse - but can't really remember the exact problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants