Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Expand" addon import to include a generated APL #2951

Open
aggixx opened this issue Oct 6, 2016 · 1 comment
Open

"Expand" addon import to include a generated APL #2951

aggixx opened this issue Oct 6, 2016 · 1 comment

Comments

@aggixx
Copy link
Contributor

aggixx commented Oct 6, 2016

I see a lot of people asking how they disable potions, flasks, food, etc when importing their character from the addon. Doing so is pretty inelegant since you basically have to simulate first, then grab the APL from the profile section of the HTML report which isn't very intuitive. Some people instead take the APL from the sample profiles which causes issues with trinket usage or anything else dynamically generated based on the actor's gear.

Not sure how the feature would work, but some way for simulationcraft to automatically expand the imported copypasta from the addon to include a default action list. Perhaps the addon can have a particularly comment denoting addon import, and then the GUI would check for that comment whenever the simulate tab is pasted into, remove it, and insert the generated APL.

@scamille
Copy link
Member

scamille commented Oct 5, 2020

There is a seaprate Simc Addon tab in the import section now.

I think a simple check box "Generate Action Priority List for custom modifications" which can be ticked there would do the trick here. But it means that the profile can not just be copied to the simulate tab, but needs to run through the simc engine which generates the APL for it, similar to how we generate the sample profiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants