Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Raidevents] Overlapping Adds event causes problems #4343

Open
Juliacare opened this issue Jun 30, 2018 · 1 comment
Open

[Raidevents] Overlapping Adds event causes problems #4343

Juliacare opened this issue Jun 30, 2018 · 1 comment
Labels

Comments

@Juliacare
Copy link
Contributor

Naming add events causing a simulation to drop drasticly in dps output.

with name: https://www.raidbots.com/simbot/report/5DHRyyTrPw6r3aJ9hSiYmo/simc
input: https://pastebin.com/raw/ySNep3Zv

without name: https://www.raidbots.com/simbot/report/ACKzLXXEcSHkf6DDCbuqz/simc
input: https://pastebin.com/raw/30ME30xw

@Juliacare Juliacare added the bug label Jun 30, 2018
@scamille scamille changed the title [Raidevents] Naming Add events causes a drop in DPS [Raidevents] Overlapping Adds event causes problems Jul 3, 2018
@scamille
Copy link
Member

scamille commented Jul 3, 2018

Ok so I renamed this into 'overlapping adds events cause trouble'.

If you only leave 1 adds event each (line 50 and 54 uncommented), DPS is fine. As I said, it would have been very fishy if raid event naming would have anything to do with it.

With overlapping add events, the whole thing doesn't even run in debug mode becaue of more safeguards there.

To be continued....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants