Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt doesn't appear anymore #523

Closed
1 of 2 tasks
tzx opened this issue Dec 29, 2019 · 12 comments · Fixed by #543
Closed
1 of 2 tasks

Prompt doesn't appear anymore #523

tzx opened this issue Dec 29, 2019 · 12 comments · Fixed by #543

Comments

@tzx
Copy link

tzx commented Dec 29, 2019

General information

System report (output of prompt_pure_system_report):

- Zsh: zsh 5.7.1 (x86_64-pc-linux-gnu)
- Operating system: Linux (#1 SMP PREEMPT Tue, 24 Dec 2019 04:36:53 +0000)
- Terminal program:  Kitty
- Git: git version 2.24.1
- Pure state:
	- username: `''`
	- prompt: `❯`
	- version: `1.10.3`
- Virtualenv: `export VIRTUAL_ENV_DISABLE_PROMPT=12`
- Prompt: `typeset -g PROMPT=$'%F{${prompt_pure_colors[path]}}%~%f
%{
%}%(12V.%F{$prompt_pure_colors[virtualenv]}%12v%f .)%(?.%F{$prompt_pure_colors[prompt:success]}.%F{$prompt_pure_colors[prompt:error]})${prompt_pure_state[prompt]}%f '`
- Detected frameworks: None

Other information

I have:

  • Tested with another terminal program and can reproduce the issue:
  • Followed the integration instructions for my framework

Problem description

My git prompt stopped appearing after updating my system. I don't know what's fully wrong but I hope someone might have this issue or may know my problem. Everything was working before; my prompt included my branch and also if there are changes to commit( the *). However, now neither of those appear.

Reproduction steps

  1. Git prompt never appears anymore. Tried it on almost every single git project that I have by cd.

My .zshrc:

My .zshrc is minimal. It only contains the aliases with COMPLETE_ALIASES, and exporting env variables. I source my antibody plugins and it only contains zsh-autosuggestions, pure, and zsh-completions. Everything was working before. I think some dependency update broke pure.

@tzx tzx changed the title Git prompt doesn't appear anymore Prompt doesn't appear anymore Dec 29, 2019
@romkatv
Copy link
Contributor

romkatv commented Dec 29, 2019

What's the output of git status in a directory where you expect Git prompt to appear?

@tzx
Copy link
Author

tzx commented Dec 29, 2019

image
Here is an example of a git repository. Notice how the branch doesn't appear anymore and it doesn't recognize if it's dirty or not.

@romkatv
Copy link
Contributor

romkatv commented Dec 29, 2019

Yep, seems broken. If git status works, I would expect Pure to show Git info in prompt.

@ehutzelman
Copy link

I'm seeing similar issues to this, but sporadically. Most of the time it works, but sometimes it will fail to update the branch status on the prompt or show the previous branch when checking out a new branch. If I close the terminal out and restart, it shows the correct information again.

@jvega
Copy link

jvega commented Feb 4, 2020

In .zshrc (oh-myzsh) I disabling/enabling the git plugin and it works again

@marciobarrios
Copy link

In .zshrc (oh-myzsh) I disabling/enabling the git plugin and it works again

Didn't work for me, with disabling you mean just commenting the line in the .zshrc file?

@romkatv
Copy link
Contributor

romkatv commented Feb 4, 2020

git plugin in Oh My Zsh simply defines a bunch of aliases. It cannot affect Pure in any way.

@tzx
Copy link
Author

tzx commented Feb 4, 2020

Just want to remind everyone that I have nothing else in zshrc other than autocompletions and aliases.

@jvega
Copy link

jvega commented Feb 4, 2020

git plugin in Oh My Zsh simply defines a bunch of aliases. It cannot affect Pure in any way.

I know that but I just toggle it git plugin and works for me

Didn't work for me, with disabling you mean just commenting the line in the .zshrc file?

no, just delete it from plugin list and put it again

also I uninstall it from npm and install it with yarn

@Freyskeyd
Copy link

I've the same issue here... anyone found a solution?

@romkatv
Copy link
Contributor

romkatv commented Feb 24, 2020

I've the same issue here... anyone found a solution?

This issue stems from zsh-async. Sometimes the background process dies and no one seems to know why. All themes that use zsh-async are affected. See mafredri/zsh-async#33 and #455. The latter issue links to a patch that attempts to detect background job crashes and to recover from them. It doesn't fix the underlying problem that leads to crashes in the first place. The only reliable solution right now is to use a theme that doesn't utilize zsh-async.

@mafredri
Copy link
Collaborator

For everyone affected by this issue, please give #543 a spin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants