Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Only intercept/manipulate packets of interest #138

Open
dorving opened this issue Jul 11, 2022 · 2 comments
Open

Feature: Only intercept/manipulate packets of interest #138

dorving opened this issue Jul 11, 2022 · 2 comments

Comments

@dorving
Copy link
Contributor

dorving commented Jul 11, 2022

Add a way for extensions to specify the packets it is interested in. That way the extension server doesn't have to forward every single packet, but only those the extension actually is interested in.

I would like to work on this once my PR for rewriting the network extensions code (#137) is merged.

@sirjonasxx
Copy link
Owner

since this would probably break backward compatibility with older extensions, we need to make sure this has practical benefit, perhaps with some small benchmarking

@dorving
Copy link
Contributor Author

dorving commented Jul 13, 2022

I was thinking we we could add an optional NetworkMessage with a list of all the packet identifiers the extensions needs.
Then the network server only forwards those, in case it receives no such message from the client, it just operates as it did before. So backward compatibility should remain intact. I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants