-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardcoded location of extra php settings for sendmail #26
Comments
In my case there should be |
Confirmed |
I suggest that we solve this by changing the We may use only
then based on
Note: this is not tested yet, so probably a copy/paste will fail, but we definitely can do this if you guys agree, so will wait for some confirmation and make a PR out of this |
Created PR #31 Some things I noted that we can fix,
We can add a
The naming used for the docker containers is not the optional iif we follow this path, for example for this to work on all versions/containers:
Source: https://github.com/skilld-labs/docker-php/blob/master/Makefile#L2 Or we can avoid to change the names and instead replace the dots inside the PR |
Here https://github.com/skilld-labs/skilld-docker-container/blob/master/src/docker/docker-compose.override.yml.default#L8
We are adding extra php settings for sendmail
I've faced whit issue when this files don't used whe we using another php version.
Reason: another directory for php ini files
The text was updated successfully, but these errors were encountered: