Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: integrate the linguist grammar compiler into CI #80

Open
fredemmott opened this issue Oct 24, 2019 · 5 comments
Open

Suggestion: integrate the linguist grammar compiler into CI #80

fredemmott opened this issue Oct 24, 2019 · 5 comments
Assignees

Comments

@fredemmott
Copy link
Contributor

Detect issues like #54, #76, #78 earlier

@PranayAgarwal PranayAgarwal self-assigned this Oct 24, 2019
@PranayAgarwal
Copy link
Member

Hey @lildude, could you point me to the syntax validator used by the linguist repo?

@fredemmott
Copy link
Contributor Author

pretty sure it's https://github.com/github/linguist/tree/master/tools/grammars/compiler

@lildude
Copy link
Contributor

lildude commented Oct 24, 2019

pretty sure it's https://github.com/github/linguist/tree/master/tools/grammars/compiler

Yup, that’s it. We push a docker image whenever we update the sauce too.

@PranayAgarwal
Copy link
Member

I wasn't able to use just the docker container for syntax validation, since it seems to still have a dependency on the repo itself.

Going the full repo route, the compilation seems to raise warnings (on stdout) but there's no way to for the call to result in an error.

@lildude any thoughts on the best approach for this?

@lildude
Copy link
Contributor

lildude commented Nov 1, 2021

I wasn't able to use just the docker container for syntax validation, since it seems to still have a dependency on the repo itself.

Interesting. I've never tried to run it independently of the repo 😁 .

Going the full repo route, the compilation seems to raise warnings (on stdout) but there's no way to for the call to result in an error.

I've not looked at this for a while but legit errors like an invalid regex should cause an error IIRC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants