Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPRECATION: Sidekiq exception handlers now take three arguments #540

Open
kikikiblue opened this issue Jul 5, 2024 · 0 comments
Open

Comments

@kikikiblue
Copy link

Ruby version: 3.3.0
Rails version: 6.1.7.7
sidekiq (7.2.4)
exception_notification (4.5.0)

my sidekiq config

url_hash = {url: "#{ENV["REDIS_TLS_URL"]}/0", ssl_params: { verify_mode: OpenSSL::SSL::VERIFY_NONE }, timeout: 3}

  Sidekiq.configure_server do |config|
    config.redis = url_hash
  end

  Sidekiq.configure_client do |config|
    config.redis = url_hash
  end

my exception notifier gem config

require 'exception_notification/rails'
require 'exception_notification/sidekiq'

ExceptionNotification.configure do |config|
  config.ignored_exceptions += %w{Net::SMTPSyntaxError}
  config.ignore_if do |exception, options|
    not Rails.env.production?
  end

  config.ignore_crawlers %w{Googlebot bingbot}
  config.error_grouping = true

  config.add_notifier :email, {
    email_prefix: "[Sidekiq Exception] ",
    sender_address: %{"no-reply" <[email protected]>},
    exception_recipients: %w{[email protected]},
  }
end

My app is on heroku but when sidekiq exception is happening, I got this DEPRECATION message.

DEPRECATION: Sidekiq exception handlers now take three arguments, see #<Proc:0x00007efde8a1f7b0 /app/vendor/bundle/ruby/3.3.0/gems/exception_notification-4.5.0/lib/exception_notification/sidekiq.rb:25

I searched and I guess that is from this line in Sidekiq
https://github.com/sidekiq/sidekiq/blob/636b4fd36786f27969b1551737e8540eb78c1c4d/lib/sidekiq/config.rb#L278

I would greatly appreciate any information anyone can provide about this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant