Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why export getDir? #22

Open
angerman opened this issue May 25, 2017 · 2 comments
Open

Why export getDir? #22

angerman opened this issue May 25, 2017 · 2 comments

Comments

@angerman
Copy link

getDir :: FilePath -> IO [(FilePath, ByteString)]

seems like a rather strange export, considering everything else that is exported is in the Q monad, and getDir is listed under Embed at compile time.

@snoyberg
Copy link
Owner

snoyberg commented May 28, 2017 via email

@angerman
Copy link
Author

The question arose out of the following patch: mobilehaskell@679b369

When making the quasi class more declarative, with separate functions for file and process io,
getDirs signature would change from

FilePath -> IO [(FilePath, ByteString)]

to

FilePath -> Q [(FilePath, ByteString)]

With getDir being exported, this then become a public api change.

The removal of getDir was pondered in #20 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants