Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework Design Optimization Proposal #1329

Closed
dajitui opened this issue Apr 21, 2023 · 7 comments
Closed

Framework Design Optimization Proposal #1329

dajitui opened this issue Apr 21, 2023 · 7 comments

Comments

@dajitui
Copy link
Contributor

dajitui commented Apr 21, 2023

Your question

@SofaService When I saw this annotation in Sofa-boot, I didn't think it was very reasonable

If I am a user, it is generally better to rely on fewer third-party packages. If I want to use Sofa-rpc now, I need to rely on Sofa-boot dependencies, which will be more important for the framework

Do you consider extracting these into the RPC module, while Sofa-boot only performs dependency and injection control? I think this framework design would be more reasonable

@OrezzerO
Copy link
Contributor

@SofaService mechanism depends on spring, but SOFA-RPC will not directly depend on spring. So, it is not suitable to add @SofaService to SOFA-RPC.

Maybe we need a simpler SOFA-RPC starter only depends on Springboot.

@dajitui
Copy link
Contributor Author

dajitui commented Apr 23, 2023

as I thought

@SofaService mechanism depends on spring, but SOFA-RPC will not directly depend on spring. So, it is not suitable to add @SofaService to SOFA-RPC.

Maybe we need a simpler SOFA-RPC starter only depends on Springboot.

yeah,as I thought

@MingJunDuan
Copy link
Contributor

This is issue is discussed in #1031, SOFA-RPC is a pure RPC framework,@SofaService only exist in sofa-boot(integrated with spring)

@dajitui
Copy link
Contributor Author

dajitui commented Apr 23, 2023

Great, it gave me an understanding of the previous design

However, there is still a problem inside. As an open source framework, it makes developers rely on Sofa-boot, which I think is unreasonable and the coupling is too heavy

As mentioned by OrezzerO above, a lightweight version of spring dependency is required

1 similar comment
@dajitui
Copy link
Contributor Author

dajitui commented Apr 23, 2023

Great, it gave me an understanding of the previous design

However, there is still a problem inside. As an open source framework, it makes developers rely on Sofa-boot, which I think is unreasonable and the coupling is too heavy

As mentioned by OrezzerO above, a lightweight version of spring dependency is required

@OrezzerO
Copy link
Contributor

Now our community does not have enough resources to open a new repo to maintain a springboot version starter.

It is not difficult to write such a starter. Maybe you can write it and donate it to SOFAStack. @dajitui

@dajitui
Copy link
Contributor Author

dajitui commented Apr 24, 2023

OK, I see

@OrezzerO OrezzerO closed this as completed Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants