metrics/metrics-prometheus/src/main/java/com/alipay/sofa/rpc/metrics/prometheus/SofaRpcMetricsCollector.java (1)

Line range hint 203-212: Consider enhancing type safety

While the current implementation handles null, Integer, and Long cases, consider adding support for other number types and better error handling.

Here's a more robust implementation:

 private static long getLongAvoidNull(Object object) {
     if (object == null) {
         return 0L;
     }
-    if (object instanceof Integer) {
-        return Long.parseLong(object.toString());
+    if (object instanceof Number) {
+        return ((Number) object).longValue();
     }
-    return (Long) object;
+    try {
+        return Long.parseLong(object.toString());
+    } catch (NumberFormatException e) {
+        return 0L;
+    }
 }

This change:

1. Handles all Number types (Integer, Long, Double, etc.)
2. Safely parses string representations
3. Falls back to 0L for unparseable values

Configuration used: CodeRabbit UI
Review profile: CHILL

metrics/metrics-prometheus/src/main/java/com/alipay/sofa/rpc/metrics/prometheus/SofaRpcMetricsCollector.java (2)

Line range hint 203-211: LGTM! The NPE fix looks good with a minor improvement suggestion.

The change from Long to long effectively prevents NPEs by returning 0L for null inputs, which is appropriate for metrics collection. However, the type handling could be more robust.

Consider making the number handling more robust:

 private static long getLongAvoidNull(Object object) {
     if (object == null) {
         return 0L;
     }
-    if (object instanceof Integer) {
+    if (object instanceof Number) {
-        return Long.parseLong(object.toString());
+        return ((Number) object).longValue();
     }
-    return (Long) object;
+    try {
+        return Long.parseLong(object.toString());
+    } catch (NumberFormatException e) {
+        return 0L;
+    }
 }

This change:

1. Handles all Number types (Integer, Long, Double, etc.)
2. Safely parses string representations
3. Provides a fallback for unparseable values

---

Inconsistent null handling in getLongAvoidNull

• SofaRpcMetricsCollector.java returns 0L when null
• SofaRpcMetrics.java returns null when null
  Review and standardize the null handling behavior to ensure consistent metrics collection.

🔗 Analysis chain

Line range hint 203-211: Verify metrics collection behavior with the new changes

The change affects how metrics are collected when null values are encountered. Let's verify the impact on metrics collection and reporting.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for potential issues with metrics collection

# Look for other metric collectors that might expect null values
rg -l "implements.*Collector" --type java

# Check for other methods that might be affected by getLongAvoidNull
rg "getLongAvoidNull" --type java -B 2 -A 2

# Look for test cases involving metrics collection
rg -l "Test.*Metrics|Metrics.*Test" --type java

Length of output: 6953

Configuration used: CodeRabbit UI
Review profile: CHILL