Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:update dubbo to 3.0.2.1,change alibaba to apache #1094

Closed
wants to merge 5 commits into from

Conversation

leizhiyuan
Copy link
Contributor

@leizhiyuan leizhiyuan commented Sep 15, 2021

Motivation:

update dubbo version

Modification:

update dubbo 3.0.2.1
update zk version
fix some local test when use dubbo 3.0.2.1

Result:

Fixes ##1065

If there is no issue then describe the changes introduced by this PR.

@sofastack-bot sofastack-bot bot added cla:yes CLA is ok size/M labels Sep 15, 2021
@leizhiyuan leizhiyuan added this to the 5.8.0 milestone Sep 15, 2021
@sofastack-bot sofastack-bot bot added size/L and removed size/M labels Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #1094 (d1aad66) into master (410d945) will increase coverage by 0.01%.
The diff coverage is 86.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1094      +/-   ##
============================================
+ Coverage     69.25%   69.26%   +0.01%     
  Complexity      827      827              
============================================
  Files           410      410              
  Lines         17859    17859              
  Branches       2761     2761              
============================================
+ Hits          12368    12370       +2     
+ Misses         4066     4065       -1     
+ Partials       1425     1424       -1     
Impacted Files Coverage Δ
...fa/rpc/bootstrap/dubbo/DubboProviderBootstrap.java 54.05% <33.33%> (ø)
...fa/rpc/bootstrap/dubbo/DubboConsumerBootstrap.java 84.21% <100.00%> (ø)
...lipay/sofa/rpc/bootstrap/dubbo/DubboConvertor.java 90.00% <100.00%> (ø)
...lipay/sofa/rpc/bootstrap/dubbo/DubboSingleton.java 88.88% <100.00%> (ø)
...n/java/com/alipay/sofa/rpc/common/SofaConfigs.java 84.90% <0.00%> (-1.89%) ⬇️
...a/com/alipay/sofa/rpc/common/utils/ClassUtils.java 80.27% <0.00%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 410d945...d1aad66. Read the comment docs.

Copy link

@Haiyoung Haiyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dubbo 3.0之后,变更了服务注册的方式,直接升级到3.0大版本,会不会有其他不兼容的feature

@EvenLjj EvenLjj modified the milestones: 5.8.0, some day Oct 25, 2021
@@ -42,6 +44,9 @@
@Test
//同步调用,走服务注册中心
public void testRegistrySync() {
System.setProperty(ConfigKeys.DUBBO_CONFIG_IGNORE_DUPLICATED_INTERFACE, "true");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is best to restore the System properties settings after this test case is completed

@stale
Copy link

stale bot commented Feb 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Feb 8, 2022
@EvenLjj EvenLjj removed the wontfix This will not be worked on label Feb 9, 2022
@stale
Copy link

stale bot commented Apr 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 10, 2022
@EvenLjj EvenLjj added the remind To be further discussed label Apr 10, 2022
@stale stale bot removed the wontfix This will not be worked on label Apr 10, 2022
@sofastack-bot sofastack-bot bot added the wontfix This will not be worked on label Apr 10, 2022
@EvenLjj EvenLjj removed the wontfix This will not be worked on label Apr 10, 2022
@Lo1nt
Copy link
Collaborator

Lo1nt commented Sep 13, 2023

already bump dubbo to 3.1.8 by #1356

@Lo1nt Lo1nt closed this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes CLA is ok remind To be further discussed size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants