Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solo key probe fails due in part to fido2.dumps #168

Open
4gra opened this issue Sep 29, 2023 · 0 comments
Open

solo key probe fails due in part to fido2.dumps #168

4gra opened this issue Sep 29, 2023 · 0 comments

Comments

@4gra
Copy link

4gra commented Sep 29, 2023

Using solo 0.1.1 from pip, with fido2 pinned to 0.9.1 so that basic things work, we still find solo key probe doesn't work:

$ solo key probe SHA256 ./example.file
[...]
    return __callback(*args, **kwargs)
  File "~/lib/python/site-packages/solo/cli/key.py", line 237, in probe
    serialized_command = fido2.cbor.dumps({"subcommand": hash_type, "data": data})
AttributeError: module 'fido2.cbor' has no attribute 'dumps'

Sure enough this hasn't existed since 2019 - dumps has been replaced by encode.

That's just the start of the problems with probe but it's a clear change that must be made to fix the error and keep up with the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant