[dpapp] Initial dpapp implementation being a vpp plugin #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @jimmyzhai - is this ready to merge? Thank you! |
|
hi @jimmyzhai it looks like we have conflicts that need to be resolved please and thank you. |
jimmyzhai
force-pushed
the
dp_app_add_vpp_plugin
branch
from
d8ad578 to
0c62cf8
Compare
r12f
reviewed
Aug 22, 2024
jimmyzhai
force-pushed
the
dp_app_add_vpp_plugin
branch
3 times, most recently
from
e2c1a02 to
1ac27da
Compare
r12f
reviewed
Sep 2, 2024
|
checking in @jimmyzhai - is this a lower priority in general? TY! |
|
just checking in :) |
jimmyzhai
force-pushed
the
dp_app_add_vpp_plugin
branch
from
1ac27da to
527a726
Compare
I'm actively updating this PR now after #608 is merged. |
|
[like] Kristina Moore reacted to your message:
…________________________________
From: Junhua Zhai ***@***.***>
Sent: Wednesday, October 30, 2024 6:30:48 AM
To: sonic-net/DASH ***@***.***>
Cc: Kristina Moore ***@***.***>; Comment ***@***.***>
Subject: Re: [sonic-net/DASH] [dpapp] Initial dpapp implementation being a vpp plugin (PR #609)
just checking in :)
I'm actively updating this PR now after #608<#608> is merged.
—
Reply to this email directly, view it on GitHub<#609 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFJSI6B6RQX6YTUMZWPPS2LZ6B4JRAVCNFSM6AAAAABLLAFHBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBVHE3TOMJUGE>.
You are receiving this because you commented.Message ID: ***@***.***>
|
jimmyzhai
force-pushed
the
dp_app_add_vpp_plugin
branch
4 times, most recently
from
fb6bab2 to
765c873
Compare
|
hi @jimmyzhai - do you need help from @chrispsommers on this one? |
jimmyzhai
force-pushed
the
dp_app_add_vpp_plugin
branch
9 times, most recently
from
276617b to
0b51e53
Compare
jimmyzhai
force-pushed
the
dp_app_add_vpp_plugin
branch
3 times, most recently
from
21306ad to
27c84a6
Compare
jimmyzhai
force-pushed
the
dp_app_add_vpp_plugin
branch
from
27c84a6 to
e0d5880
Compare
jimmyzhai
force-pushed
the
dp_app_add_vpp_plugin
branch
from
7ddc499 to
073d10d
Compare
r12f
approved these changes
Nov 21, 2024
r12f
reviewed
Nov 21, 2024
jimmyzhai
force-pushed
the
dp_app_add_vpp_plugin
branch
from
e5e9af3 to
ea693a1
Compare
1. not enable dpdk_plugin.so, then not need hugepage allocation 2. Update NODE_FN dash_node to be simple
jimmyzhai
force-pushed
the
dp_app_add_vpp_plugin
branch
from
cae69c5 to
b52014d
Compare
r12f
reviewed
Nov 25, 2024
r12f
approved these changes
Nov 27, 2024
|
@r12f - should I merge this one? |
|
Hi Kristina, I think so. It has been a while. The design is following the HLD. All the comments are resolved and didn't see any other comments too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following dpapp HLD - #606, this is the 3th part implementation. It implements the basic logic of inline flow creation, deletion and ageout.
make dpappmake run-dpapp