[sonic_eeprom] Add unit test for eeprom_tlvinfo_test #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lizhuhuams @sujinmkang please review |
lizhuhuams
reviewed
Jul 5, 2022
| assert(tf == True) | ||
| assert(s[2].decode() == "3HE16794AARA01") | ||
|
|
||
| assert(tlvInfo.base_mac_addr(e) == "50:E0:EF:51:27:91") |
There was a problem hiding this comment.
I assume MAC address is configured per device. So it cannot always be 50:E0:ED:51:27:91, right?
How come platform name is not tested?
Can CRC be tested?
lizhuhuams
reviewed
Jul 8, 2022
|
|
||
| (tf, s) = tlvInfo.get_tlv_field(e, tlvInfo._TLV_CODE_PRODUCT_NAME) | ||
| assert(tf == True) | ||
| assert(s[2].decode() == "7215 IXS-T1") |
There was a problem hiding this comment.
this is common code, pleas do not assume your product name on line 52 and part number on line 56.
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
* [ycabled] remove some spurious logs For Ports which do not belong to active-active or active-standby type, we should not try to post muxcable telemetry information for them. This PR remove the warning message for such a posting. Also fixes the PR pipeline by changing the ConsumerTable to SubscriberStateTable Signed-off-by: vaibhav-dahiya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added unit test for eeprom_tlvinfo.py tool
Motivation and Context
Greater than 50% unit test code coverage required for PRs
How Has This Been Tested?
Unit test passes and code coverage requirement met