Implement is_copper for QSFP-DD #482
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
prgeor
reviewed
Sep 9, 2024
| @@ -703,6 +703,18 @@ def get_module_media_interface(self): | |||
| else: | |||
| return 'Unknown media interface' | |||
|
|
|||
| def is_copper(self): | |||
There was a problem hiding this comment.
@jcsteven why not use is_flat_memory()
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
* [xcvrd] Fix issue: logical_port_name is not defined * Add UT --------- Co-authored-by: Prince George <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add is_copper() api for QSFP-DD.
Motivation and Context
While I tested with as9726-32d and as9736-64d with QSFP-DD transceiver via adding is_copper() in my modified sfputil tools, it shows that is_copper() not implemented for QSFP-DD.
In this PR is to add the is_copper() in sonic_platform_base/sonic_xcvr/api/public/cmis.py and its pytest feature for this api.
How Has This Been Tested?
A. Git clone the fixed code:
B. Install pip dependencie in virtual environment
C. Run the pytest:
Additional Information (Optional)
Test log as: test_cmis.py-test-log.txt
Test summary: